Merged
Conversation
|
|
Contributor
Author
|
Closes #1973 |
sipeed-bot
bot
added
type: enhancement
SiYue-ZO
changed the title
SiYue-ZO
force-pushed
the
feature/unified-restart-required
branch
from
9d1d75d to
297a6c6
Compare
Collaborator
|
plz fix Linter @SiYue-ZO |
- Add bootConfigSignature to gateway state for tracking restart-sensitive config - Implement computeConfigSignature() to capture model and tool enabled states - Add gatewayRestartRequiredBySignature() for unified restart detection - Update gatewayStatusData() to use signature-based comparison - Preserve backward compatibility with existing boot_default_model field
- TestGatewayStatusRequiresRestartAfterToolChange: verify tool toggle triggers restart hint - TestGatewayStatusNoRestartRequiredForNonSensitiveChanges: verify non-sensitive changes don't trigger - TestGatewayStatusNoRestartRequiredWhenNotRunning: verify no restart hint when gateway stopped - Update resetGatewayTestState to clear bootConfigSignature
- ToolsPage: call refreshGatewayState after tool toggle success - ConfigPage: call refreshGatewayState after config save success - RawConfigPage: call refreshGatewayState after raw JSON save success - Ensures restart-required indicator updates immediately after changes
- Update restartRequired message from model-specific to generic config change - zh: '切换默认模型后需要重启服务才能生效' -> '配置变更后需要重启服务才能生效' - en: 'Model changes require a gateway restart' -> 'Configuration changes require a gateway restart' - Reflects unified restart detection for model/tools/config changes
Contributor
Author
|
I will fix it |
SiYue-ZO
force-pushed
the
feature/unified-restart-required
branch
from
8de0be6 to
0858b16
Compare
Contributor
Author
|
I've fixed Linter @yinwm |
yinwm
approved these changes
Mar 28, 2026
Collaborator
yinwm
left a comment
yinwm
left a comment
There was a problem hiding this comment.
LGTM. The signature-based approach cleanly extends the restart-required detection from model-only to model+tools+config. Good test coverage with the 3 new test cases. Frontend changes are minimal and correct.
Non-blocking note: consider adding a comment above computeConfigSignature() reminding maintainers to update the tool list when new tools are added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Unify the restart-required detection and notification mechanism so that model, tool, and configuration changes all follow the same logic, preventing user confusion.
Key Changes:
Backend: Unified Restart Detection
bootConfigSignatureto track restart-sensitive configuration at gateway startupcomputeConfigSignature()to capture default model and tool enabled statesgatewayRestartRequiredBySignature()for unified restart detectiongatewayStatusData()to use signature-based comparisonFrontend: State Synchronization
Copy Unification
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
Fixes inconsistent restart-required notification behavior across model, tool, and configuration changes.
📚 Technical Context (Skip for Docs)
🧪 Test Environment
📸 Evidence (Optional)
Click to view Test Results
☑️ Checklist